This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
List: add @fp-ts/core@0.0.6 instances and 100% test coverage
#90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more a showcase of what can be derived from the instances.
We can either merge it as is and later remove the superfluous functions or, if you mark the not interesting ones, I can remove them in a forthcoming commit.
There's also a fix for the
takefunction.src/internal/List
The new functions defined in
src/internal/Listare not optimisedproductproductManyproductAllreduceRightfilterMapcompactThe following pre-existing functions
filterpartitionpartitionMapare no more used by
src/List(they are now derived), can I remove them?test/List
added 100% coverage