Replace Fluture with Wave #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikearnaldi
force-pushed
the
waveguide
branch
from
035a05e
to
f964261
Compare
fubhy
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons:
Arguably the final type is very equal to the already implemented
WaveRbut the instances differ, the key difference is the Monad3E and the overloadings for Do that have been tuned to better support R & E overall we would say this implementation pose primary interest on the full data type <R, E, A> where in wave the primary interest on the <E, A>.Additional work is needed to better expose Queue/Managed/etc
Closes #10