Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if performance.timeOrigin is 0, use performance.now() directly in Clock #3247

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

tim-smart
Copy link
Member

No description provided.

Copy link

changeset-bot bot commented Jul 13, 2024

🦋 Changeset detected

Latest commit: c132863

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
effect Patch
@effect/cli Patch
@effect/cluster-browser Patch
@effect/cluster-node Patch
@effect/cluster-workflow Patch
@effect/cluster Patch
@effect/experimental Patch
@effect/opentelemetry Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/platform Patch
@effect/printer-ansi Patch
@effect/printer Patch
@effect/rpc-http Patch
@effect/rpc Patch
@effect/schema Patch
@effect/sql-d1 Patch
@effect/sql-drizzle Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/sql Patch
@effect/typeclass Patch
@effect/vitest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart tim-smart merged commit ca775ce into main Jul 13, 2024
12 checks passed
@tim-smart tim-smart deleted the clock-cloudflare branch July 13, 2024 09:36
@github-actions github-actions bot mentioned this pull request Jul 13, 2024
@johtso
Copy link
Contributor

johtso commented Jul 13, 2024

After some investigation it seems like this is an inconsistency between miniflare and the live cloudflare runtime. Really Date.now() and performance.now() should both return 0.. but due to a quirk in miniflare Date.now() returns the current time even pre-io, but performance.now() returns 0.

cloudflare/workers-sdk#6261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants