homework-5 (with bonus) #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
Betorov
approved these changes
Apr 7, 2024
| public final class TimeConstants { | ||
|
|
||
| public final static OffsetDateTime MIN_DATE_TIME = | ||
| OffsetDateTime.parse("0001-01-01T00:00:00Z"); |
There was a problem hiding this comment.
Подправил на OffsetDateTime.now()
Comment on lines
15
to
89
| public class BranchDao { | ||
|
|
||
| private final JdbcTemplate jdbcTemplate; | ||
|
|
||
| @Transactional | ||
| public boolean exists(Branch branch) { | ||
| String countSql = """ | ||
| SELECT COUNT(*) AS row_count\s | ||
| FROM "Branch"\s | ||
| WHERE repository_owner = ? AND repository_name = ? AND branch_name = ? | ||
| """; | ||
| var rowCount = jdbcTemplate.queryForObject( | ||
| countSql, | ||
| Integer.class, | ||
| branch.getRepositoryOwner(), | ||
| branch.getRepositoryName(), | ||
| branch.getBranchName() | ||
| ); | ||
| return rowCount != null && rowCount == 1; | ||
| } | ||
|
|
||
| @Transactional | ||
| public void add(Branch branch) { | ||
| String sql = """ | ||
| INSERT INTO "Branch" (repository_owner, repository_name, branch_name, last_commit_time)\s | ||
| VALUES (?, ?, ?, ?) | ||
| """; | ||
| jdbcTemplate.update( | ||
| sql, | ||
| branch.getRepositoryOwner(), | ||
| branch.getRepositoryName(), | ||
| branch.getBranchName(), | ||
| branch.getLastCommitTime() | ||
| ); | ||
| } | ||
|
|
||
| @Transactional | ||
| public void delete(Branch branch) { | ||
| if (!exists(branch)) { | ||
| throw new InvalidDataAccessResourceUsageException("Branch not found!"); | ||
| } | ||
|
|
||
| String sql = """ | ||
| DELETE FROM "Branch"\s | ||
| WHERE repository_owner = ? AND repository_name = ? AND branch_name = ? | ||
| """; | ||
| jdbcTemplate.update( | ||
| sql, | ||
| branch.getRepositoryOwner(), | ||
| branch.getRepositoryName(), | ||
| branch.getBranchName() | ||
| ); | ||
| } | ||
|
|
||
| @Transactional | ||
| public List<Branch> findAll() { | ||
| String sql = "SELECT * FROM \"Branch\""; | ||
| return jdbcTemplate.query(sql, (rs, rowNum) -> | ||
| new Branch( | ||
| rs.getLong("id"), | ||
| rs.getString("repository_owner"), | ||
| rs.getString("repository_name"), | ||
| rs.getString("branch_name"), | ||
| rs.getObject("last_commit_time", OffsetDateTime.class) | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Transactional | ||
| public List<Branch> findAllByOwnerAndName(String owner, String name) { | ||
| String sql = "SELECT * FROM \"Branch\" WHERE repository_owner = ? AND repository_name = ?"; | ||
| return jdbcTemplate.query(sql, (rs, rowNum) -> | ||
| new Branch( | ||
| rs.getLong("id"), | ||
| rs.getString("repository_owner"), | ||
| rs.getString("repository_name"), | ||
| rs.getString("branch_name"), | ||
| rs.getObject("last_commit_time", OffsetDateTime.class) | ||
| ), owner, name | ||
| ); | ||
| } |
There was a problem hiding this comment.
BranchDao?
В задании 5-ом хотели реализовать через интерфейс, BranchDao, JdbcBranchDao, JooqBranchDao и т.д..
There was a problem hiding this comment.
jooq, Предлагаю создать отдельный модуль где будет лежать вся модель. ? Почему, потому что ее часто приходится перегенирировать. И будет аккуратнее выглядеть
Betorov
reviewed
Apr 7, 2024
Comment on lines
19
to
32
| @Transactional | ||
| public boolean exists(Branch branch) { | ||
| String countSql = """ | ||
| SELECT COUNT(*) AS row_count\s | ||
| FROM "Branch"\s | ||
| WHERE repository_owner = ? AND repository_name = ? AND branch_name = ? | ||
| """; | ||
| var rowCount = jdbcTemplate.queryForObject( | ||
| countSql, | ||
| Integer.class, | ||
| branch.getRepositoryOwner(), | ||
| branch.getRepositoryName(), | ||
| branch.getBranchName() | ||
| ); | ||
| return rowCount != null && rowCount == 1; | ||
| } |
There was a problem hiding this comment.
У всех какая-то общая проблема. Создают транзакцию избыточно.
На селекте то она зачем?
| ); | ||
| } | ||
|
|
||
| @Transactional |
There was a problem hiding this comment.
В одной бизнес-логике используется несколько транзакций, точно он так нужно? Может мы должны удалить в одном месте и в другом сразу?
Транзакция выглядит избыточной.
Обычно ее вставляют когда в бизнес-логике идет работа с БД (а тут с несколькими таблицами сразу)
|
Здравствуйте! Если что, отписал в телеграм по поводу правок |
… homework-5-with-bonus
…ges from homework-5-with-bonus
…into environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Бот отслеживает следующие сценарии:
Github:
Stackoverflow: