-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configprovider: add support for gradient and individual component theme containers #783
Merged
dkilgore-eightfold
merged 10 commits into
EightfoldAI:main
from
dkilgore-eightfold:dkilgore-eightfold/add-gradient-and-component-theme-container-support
Feb 23, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt theme containers
dkilgore-eightfold
requested review from
ypike-eightfold,
jhoward-eightfold,
thiyagaraj-eightfold and
ayadav-eightfold
February 13, 2024 02:18
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #783 +/- ##
==========================================
- Coverage 84.83% 84.37% -0.47%
==========================================
Files 999 1008 +9
Lines 19552 19866 +314
Branches 7302 7530 +228
==========================================
+ Hits 16587 16762 +175
- Misses 2885 3022 +137
- Partials 80 82 +2 ☔ View full report in Codecov by Sentry. |
ypike-eightfold
approved these changes
Feb 14, 2024
…t-theme-container-support
…t-theme-container-support
…with status updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
linear-gradient
css variables and mappingsConfigProvider
to add aGradient
context andgradient
propConfigProvider
to add aTheme
contextstyleGenerator
to add gradient theme and individual scoped component theme containers supportAccordion
,Button
,Carousel
,Dialog
,InfoBar
,LinkButton
,Modal
,Pagination
,Panel
,PanelHeader
,Pill
,Snackbar
,Stepper
,Stat
, andUpload
Accordion
,Breadcrumb
,Button
,Carousel
,CheckBox
,Dialog
InfoBar
,Link
,LinkButton
,MatchScore
Modal
,Pagination
,Panel
,PanelHeader
,PersistentBar
,Progress
,RadioButton
,Tabs
,TextArea
,TextInput
,SearchBar
,Select
,Slider
,Snackbar
, andUpload
(Pill
SkillTag
,SkillBlock
,Stat
andStepper
use a less efficient legacy implementation - keeping 'as-is' for now)border-radius
is0
in fullscreenModal
Pill
component where theButton
counter was not being themed properly and its insets were wrongMenuItemButton
styles to align a bit better withButton
colorInvert
prop and its styles toTabs
pill
variant.ConfigProvider
storiesGradient
andTheme
context providers and their typesButton
where itscounter
spacing was too tight when there was no labelTwoStateButton
where its text color was usingaccent
palette instead ofbluegreen
themes.ts
so its arrays don't need to bereverse()
and the hexidecimal casing is in line with the modulesInfoBar
to usebackground
, rather thanbackground-color
InputStatus
to includehighlight
and applies updates status styles toTextArea
,TextInput
,SearchBar
,Select
,TimePicker
, andDatePicker
--violet-color-30
to match the design specificationButton
An example where a button was changed to
ButtonVariant.Primary
withgradient
,theme="blueViolet"
andconfigContextProps={{ noThemeContext: true }}
in a local test.Storybook
https://github.com/EightfoldAI/octuple/assets/99700808/9222e250-f487-4f2b-8dc3-6277397fefdd
JIRA TASK (Eightfold Employees Only):
ENG-78260
ENG-78250
ENG-77347
ENG-77346
ENG-76044
ENG-76043
ENG-76042
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theConfigProvider
,Accordion
,Button
,Carousel
,CheckBox
,Dialog
,InfoBar
,Link
,LinkButton
,MatchScore
,Modal
,Pagination
,Panel
,PersistentBar
,Pill
,Progress
,RadioButton
,TextArea
,TextInput
,SearchBar
,Select
,Slider
,Snackbar
,Stepper
,Timeline
,Tabs
,TimePicker
,DatePicker
, andUpload
stories behave as expected.