61 update openai client #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mkrueger12
commented
Jan 5, 2024
mkrueger12
commented
- Updated OpenAI and Cohere so the response is marshaled into each providers given response struct then into the Unified Response
Closed
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #62 +/- ##
===========================================
- Coverage 68.03% 66.14% -1.89%
===========================================
Files 11 11
Lines 463 449 -14
===========================================
- Hits 315 297 -18
- Misses 125 128 +3
- Partials 23 24 +1 ☔ View full report in Codecov by Sentry. |
roma-glushko
reviewed
Jan 6, 2024
| } | ||
|
|
||
| // ProviderResponse contains data from the chosen provider | ||
| // ProviderResponse is the unified response from the provider. | ||
|
|
||
| type ProviderResponse struct { |
There was a problem hiding this comment.
Should this one be called ModelResponse too?
| // ChatChoice is a choice in a chat response. | ||
| type ChatChoice struct { | ||
| // OpenAI Chat Response | ||
| // TODO: Should this live here? |
There was a problem hiding this comment.
@mkrueger12 I would move it under OpenAI package. api/schemas was meant to be for Glide API schemas (e.g. unified schemas for whatever endpoints we provide).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.