Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid having to set SIMD_CPU for GPU builds #68

Open
rhaas80 opened this issue Apr 5, 2023 · 1 comment
Open

avoid having to set SIMD_CPU for GPU builds #68

rhaas80 opened this issue Apr 5, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@rhaas80
Copy link
Member

rhaas80 commented Apr 5, 2023

Instead of expecting the user to set `SIMD_CP`U for GPU builds it may be possible to check of AMReX itself was built with GPU support (via AMREX_USE_GPU which is defined in AMReX/include/AMReX_Config.H).

@rhaas80 rhaas80 added the enhancement New feature or request label Apr 5, 2023
@eschnett
Copy link
Collaborator

This is also necessary for ROCM.

The problem is that neither nvcc nor hipcc can handle the Intel SIMD intrinsics. They report errors when reading the respective header files for various reasons, e.g. hipcc claims that float16 is not a type that can be vectorized. (It can.) We thus need to disable SIMD vectorization for these compilers. This is more of a compiler problem that we need to work around than a fundamental design issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants