License Header is removed from 3.1.0 release

[hazendaz]

I looked over the change log but not seeing any direct mention of what has occurred. My best guess is that something in the jdom 2 upgrade. With 3.0.1, license header in pom.xml is left alone. In 3.1.0, it is deleted. Was this intential? Is there some way to work around the issue?

[Ekryd]

Well, the handling of DocType in the XML has been removed due to vulnerability issues. Do you have an example xml?

[hazendaz]

sure you can run it against this https://github.com/hazendaz/base-parent/blob/master/pom.xml with simple sortpom:sort which Results in license header removal which is just a comment.

[dwalluck]

I see also that <ignore /> has been changed to <ignore/>. I think that as a general rule, sortpom should not modify any kind of whitespace, unless it's also meant to be a code formatting tool.

[hazendaz]

@dwalluck the 'ignore' can be ignored. I didn't run it with parameters that would not do that. My only issue is the license header is being removed. If I ran all the parameters I use it would have left that bit alone. The example here was just for a quick project to look at that shows the issue.

[hazendaz]

@dwalluck Use <spaceBeforeCloseEmptyElement>true</spaceBeforeCloseEmptyElement> to ensure the whitespace change doesn't occur. Sorry didn't have that in my example. I have updated my config to include that and re-ran to show the proper screen shot of the consideration on this issue.

[dwalluck]

OK, so your config changed?

I filed #206 and thought that it might be related to that issue.

In my case, I have not changed anything, so I wouldn't expect anything to change (by default, anyway).

[hazendaz]

I had not changed anything either. The repo I saw this on first is not public. So I added a quick check on one I have that is public that did not use same configuration. If i recall, that configuration with the whitespace removal actually changed with 3.0.0 of this plugin.

So now my private and public repo have same configuration, same issue noted here with license header being removed.

[Ekryd]

Thanks for the example. Removing the comment sounds suspicious. I’ll have a look at it.

[Ekryd]

This is a problem. When the root element is added to a newly created xml document, all content is cleared (including the comment). I will work on a fix as soon as possible.

[create-issue-branch]

Branch issue-205-License_Header_is_removed_from_3_1_0_release created!

[Ekryd]

Found the problem. Will issue a new version

[Ekryd]

This should be fixed with version 3.1.1. @hazendaz please try it out and report if it fixes your problem

[hazendaz]

Confirmed fixed. Thank you! Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Björn Ekryd ***@***.***> Sent: Tuesday, May 24, 2022 2:56:33 PM To: Ekryd/sortpom ***@***.***> Cc: Jeremy Landis ***@***.***>; Mention ***@***.***> Subject: Re: [Ekryd/sortpom] License Header is removed from 3.1.0 release (Issue #205) This should be fixed with version 3.1.1. @hazendaz<https://github.com/hazendaz> please try it out and report if it fixes your problem — Reply to this email directly, view it on GitHub<#205 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHODI6EBGLIJ5HRVSEV2MTVLUQ6DANCNFSM5WWDIWWQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[dwalluck]

Fixed for me, too.

[Ekryd]

Great! I hope that you are satisfied with SortPom and thanks for reporting the issue