Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[andino_base] explicitly add <cstdint> header for fixed width integer types #254

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Sakura286
Copy link
Contributor

@Sakura286 Sakura286 commented Jun 7, 2024

🦟 Bug fix

Summary

When build with gcc 13, introducing fixed width integer types need to explicitly add header. This is a common issue when migrating ros2 package to Ubuntu Noble.

Here is the build log (build with gcc 13.2):

23:20:06 In file included from /usr/include/libserial/SerialPort.h:36,
23:20:06                  from /tmp/binarydeb/ros-humble-andino-base-0.1.0/include/andino_base/motor_driver.h:34,
23:20:06                  from /tmp/binarydeb/ros-humble-andino-base-0.1.0/src/motor_driver.cpp:30:
23:20:06 /usr/include/libserial/SerialPortConstants.h:93:37: error: ���uint8_t��� was not declared in this scope
23:20:06    93 |     using DataBuffer =  std::vector<uint8_t> ;
23:20:06       |                                     ^~~~~~~
23:20:06 /usr/include/libserial/SerialPortConstants.h:41:1: note: ���uint8_t��� is defined in header ���<cstdint>���; did you forget to ���#include <cstdint>���?
23:20:06    40 | #include <vector>
23:20:06   +++ |+#include <cstdint>
23:20:06    41 | 

see:

SICKAG/sick_safetyscanners_base#30
https://gcc.gnu.org/gcc-13/porting_to.html

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Sakura286 <sakura286@outlook.com>
@francocipollone
Copy link
Collaborator

Hey @Sakura286 thanks for the contribution. Are you targeting to create an andino with ROS Jazzy?
We are doing the migration to support Jazzy/Noble as well, hope we can have it soon.

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francocipollone francocipollone merged commit 8711526 into Ekumen-OS:humble Jun 7, 2024
4 checks passed
@Sakura286
Copy link
Contributor Author

Are you targeting to create an andino with ROS Jazzy?

Currently I am porting ROS2 Humble repo to Debian unstable riscv64, and may build Jazzy later. I am glad to give some feedback with the new release of this package.

@francocipollone
Copy link
Collaborator

Are you targeting to create an andino with ROS Jazzy?

Currently I am porting ROS2 Humble repo to Debian unstable riscv64, and may build Jazzy later. I am glad to give some feedback with the new release of this package.

Nice, thanks for sharing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants