Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ament_clang_format from system tests #155

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Mar 29, 2023

Related to #154.

Summary

The configuration for clang_format and clang_tidy was moved to the root of the repository in #133.
This patch removes the call to both ament_clang_format and ament_clang_tidy from the system test package.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added bug Something isn't working infra Related to infrastructure and CI labels Mar 29, 2023
@nahueespinosa nahueespinosa self-assigned this Mar 29, 2023
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa merged commit 00accc1 into main Mar 29, 2023
@nahueespinosa nahueespinosa deleted the nahuel/fix-system-test branch March 29, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infra Related to infrastructure and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants