Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Git LFS from the repository #162

Merged
merged 4 commits into from
Apr 17, 2023
Merged

Remove Git LFS from the repository #162

merged 4 commits into from
Apr 17, 2023

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Apr 17, 2023 •
edited
Loading

Related to #154.

Summary

As the title says, 15MB doesn't justify using Git LFS yet.

Checklist

  • Read the contributing guidelines.
  • Configured pre-commit and ran colcon test locally.
  • Signed all commits for DCO.
  • Added tests (regression tests for bugs, coverage of new code for features).
  • Updated documentation (as needed).
  • Checked that CI is passing.

@nahueespinosa
Remove Git LFS from the repository
67f1bc7 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Restore file contents
f3b6271 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Update README
e3517e5 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa nahueespinosa added enhancement New feature or request infra Related to infrastructure and CI labels Apr 17, 2023
@nahueespinosa nahueespinosa self-assigned this Apr 17, 2023
ivanpauno
ivanpauno approved these changes Apr 17, 2023
View reviewed changes
Copy link
Collaborator

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could also remove git-lfs from the ci workflow, otherwise LGTM!

@ivanpauno
Copy link
Collaborator

here and here

@nahueespinosa
Remove Git LFS from the CI workflow
05235d3 
Signed-off-by: Nahuel Espinosa <nespinosa@ekumenlabs.com>
@nahueespinosa
Copy link
Member Author

Done. Thanks!

@nahueespinosa nahueespinosa merged commit cd40f99 into main Apr 17, 2023
@nahueespinosa nahueespinosa deleted the nahuel/remove-git-lfs branch April 17, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpauno ivanpauno ivanpauno approved these changes

Assignees

@nahueespinosa nahueespinosa

Labels
enhancement New feature or request infra Related to infrastructure and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahueespinosa @ivanpauno