Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add likelihood field pre-computation #24

Merged
merged 6 commits into from
Dec 6, 2022
Merged

Conversation

nahueespinosa
Copy link
Member

@nahueespinosa nahueespinosa commented Dec 5, 2022

This patch adds the likelihood field pre-computation step as described in Probabilistic Robotics, Chapter 6.4.1.
This will be used to compute the importance weights from particles in a follow-up PR.

Related to #3.

image

@nahueespinosa nahueespinosa self-assigned this Dec 5, 2022
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass

beluga_amcl/include/beluga_amcl/models.hpp Outdated Show resolved Hide resolved
beluga_amcl/include/beluga_amcl/models.hpp Show resolved Hide resolved
beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
Base automatically changed from nahuel/flatland to master December 5, 2022 19:19
@nahueespinosa
Copy link
Member Author

@hidmic Thanks for the review! Let me know if you have more comments.

hidmic
hidmic previously approved these changes Dec 6, 2022
Copy link
Collaborator

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

beluga_amcl/src/amcl_node.cpp Outdated Show resolved Hide resolved
@nahueespinosa nahueespinosa merged commit 803b24f into master Dec 6, 2022
@nahueespinosa nahueespinosa deleted the nahuel/likelihood branch December 6, 2022 18:08
@nahueespinosa nahueespinosa added enhancement New feature or request cpp Related to C++ code labels Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpp Related to C++ code enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants