Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use WKWebView instead of UIWebView #4

Open
coolstar opened this issue Feb 9, 2018 · 5 comments
Open

Use WKWebView instead of UIWebView #4

coolstar opened this issue Feb 9, 2018 · 5 comments

Comments

@coolstar
Copy link
Collaborator

coolstar commented Feb 9, 2018

UIWebView is not optimal on iOS 11 as we can't enable JIT when Cydia is outside the container:

Sandbox: Cydia(14974) System Policy: deny(1) dynamic-code-generation
Cydia(14974) System Policy: MAP_JIT requires sandboxing

The obvious fixes are to either disable JIT (too slow), or have Cydia use WKWebView (preferred solution).

Would be a good idea to have the change be compilable in a separate dylib so we don't have to recompile the main Cydia app ourselves and can just edit the binary load commands.

@ElectraJailbreak ElectraJailbreak deleted a comment from malters23 Feb 9, 2018
@Detrodus
Copy link

Detrodus commented Feb 9, 2018

I am really new to this, please help. I know little about this or any coding. I am very interested in this but have no idea where to start.

@nullpixel
Copy link
Contributor

please guys, you should know better than hijacking issues

@ElectraJailbreak ElectraJailbreak deleted a comment from malters23 Feb 9, 2018
@ElectraJailbreak ElectraJailbreak deleted a comment from malters23 Feb 9, 2018
@ElectraJailbreak ElectraJailbreak deleted a comment from flooppolf Feb 9, 2018
@eilpx
Copy link

eilpx commented Feb 9, 2018

Would it be a bad idea to recompile the whole Cydia?

@kirb
Copy link

kirb commented Feb 9, 2018

This is probably a bigger undertaking than you'd expect due to how tightly Cydia is integrated with WebKit. It'd partly be a downgrade as the cydia API exposed to JavaScript would no longer be directly calling native code, instead it has to use postMessage() to communicate.

@jlippold
Copy link

I'm noticing a 30 second lag when first injecting content into cydia's webviews with my tweak https://github.com/jlippold/tweakCompatible and I assume it is related to this issue?

Is there any workaround, or any ideas how to speed it up? Maybe I shouldn't be using the [webView performSelectorOnMainThread] method as seen here? https://github.com/jlippold/tweakCompatible/blob/master/Tweak.xm#L334

Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants