Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Electron version to 30.0.3 #852

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

rs22
Copy link

@rs22 rs22 commented May 10, 2024

This updates the electron version to 30.0.3. It does not include any changes regarding new, updated or possibly deprecated APIs (I haven't checked).

The support timeframes for individual Electron versions are quite short. Support for the current version 30 ends on October 15 2024 (https://www.electronjs.org/docs/latest/tutorial/electron-timelines).

I did a quick successful smoke test with the API demos project:
Screenshot 2024-05-10 at 17 09 43

@FlorianRappl
Copy link
Collaborator

Looks good to me - we'd also need an entry in the changelog.

Retarget to develop.

@FlorianRappl FlorianRappl changed the base branch from main to develop May 10, 2024 15:24
@rs22
Copy link
Author

rs22 commented Jun 4, 2024

Should I create a changelog entry as part of this PR (and assign a new Electron.NET version)?

Let me know if any other changes are needed for a merge.

@FlorianRappl
Copy link
Collaborator

Should I create a changelog entry as part of this PR (and assign a new Electron.NET version)?

Yes please (I'd propose to make a new section "30.0.3" with (none) being the entry in each section for now; see https://raw.githubusercontent.com/ElectronNET/Electron.NET/main/Changelog.md).

@rs22
Copy link
Author

rs22 commented Jun 4, 2024

Changelog is now updated. Sorry for the large diff: my editor automatically trimmed some trailing whitespace.

Copy link
Collaborator

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FlorianRappl FlorianRappl merged commit 4c880cb into ElectronNET:develop Jun 4, 2024
2 of 3 checks passed
@rs22 rs22 deleted the update-electron-30 branch June 4, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants