Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CascaderPanel: fix bug in parent node and child node have the same value on lazy load mode #16809

Closed
wants to merge 1 commit into from

Conversation

EHfive
Copy link

@EHfive EHfive commented Jul 30, 2019

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow Element's contributing guide (中文 | English | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer relative issues for you PR.

relative PRs: #15935 #16420

@element-bot
Copy link
Member

element-bot commented Jul 30, 2019

Deploy preview for element ready!

Built with commit 4861fdb

https://deploy-preview-16809--element.netlify.com

@EHfive
Copy link
Author

EHfive commented Jul 30, 2019

#15935 使 Store.prototype.getNodeByValue(value)value可以匹配node.path获取Node解决了父子node.value重复问题

#16809 由于传入 Store.prototype.getNodeByValue(value) 的value不是路径, 使父子value相同会导致回显失败

@ziyoung
Copy link
Contributor

ziyoung commented Jul 31, 2019

请提供个 demo。

@EHfive
Copy link
Author

EHfive commented Jul 31, 2019

@stale
Copy link

stale bot commented Jul 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 30, 2020
@EHfive
Copy link
Author

EHfive commented Jul 30, 2020

Still in v2.13.2

https://codepen.io/ehfive/pen/NWxZYXm

@stale stale bot removed the stale label Jul 30, 2020
@stale
Copy link

stale bot commented Aug 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 21, 2021
@EHfive
Copy link
Author

EHfive commented Aug 21, 2021

Still in v2.15.5, https://codepen.io/ehfive/pen/NWxZYXm (same URL as above).

The PR seems can still be applied. But I am not sure if I got enough energy to following up on the PR.

@stale stale bot removed the stale label Aug 21, 2021
@EHfive EHfive closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants