Table: fix table header slot not reactive #21297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for element ready! 🔨 Explore the source changes: bbed981 🔍 Inspect the deploy log: https://app.netlify.com/sites/element/deploys/61320b3625971c00079b4194 😎 Browse the preview: https://deploy-preview-21297--element.netlify.app/ |
|
We need this released. |
zhongwenandyiming
pushed a commit
to zhongwenandyiming/element
that referenced
this pull request
Jun 13, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #20453
只有slot的情况下，table-header无法收集到slot组件下的依赖信息，造成了data的改变没有触发table-header更新。
pr里的解决方案是：有设置slot情况下，在beforeUpdate时，重新给renderHeader赋值，触发table-header的更新。
devbranch.