Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assess current value of g_con_elementsmode and consider removal #929

Closed
apoelstra opened this issue Nov 24, 2020 · 1 comment
Closed

Assess current value of g_con_elementsmode and consider removal #929

apoelstra opened this issue Nov 24, 2020 · 1 comment

Comments

@apoelstra
Copy link
Member

@instagibbs can you offer some insight into why we have this?
@apoelstra apoelstra mentioned this issue Dec 3, 2020
Merged
@apoelstra
Copy link
Member Author

Closing. In short, g_con_elementsmode is needed or else we would need to regenerate a huge proportion of the unit tests and functional tests, and continue to do this on an ongoing basis as Core adds news tests. I no longer consider removal of g_con_elementsmode to be a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apoelstra