listpeers: include private field in channels output
#2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustyrussell
approved these changes
Jan 8, 2019
tests/test_connection.py
Outdated
| @@ -805,6 +805,12 @@ def test_private_channel(node_factory): | |||
| assert not l1.daemon.is_in_log('Received node_announcement for node {}'.format(l2.info['id'])) | |||
| assert not l2.daemon.is_in_log('Received node_announcement for node {}'.format(l1.info['id'])) | |||
|
|
|||
| # test for 'private' flag in rpc output | |||
| assert len(l1.rpc.listpeers()) == 1 | |||
There was a problem hiding this comment.
I don't think this does what you want? This passes because the output only has one field 4, "peers".
The next line checks there's only one entry in the peers array: only_one asserts that
There was a problem hiding this comment.
Right, this check isnt' really checking anything worthwhile, rm'd.
Reveal channel's 'privacy' in `listpeers` output Suggested-By: @shesek
niftynei
force-pushed
the
nifty/add_private_flag_to_channel_output
branch
from
5065646 to
7154738
Compare
|
Cool. Test for non-private channel's flag is one line down :) |
niftynei
commented
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reveal channel's 'privacy' in
listpeersoutputSuggested-By: @shesek