Updated feature work #3002
Merged
Updated feature work #3002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We need it to put in the error code for WIRE_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This removes the WIRE_FINAL_EXPIRY_TOO_SOON which leaked too much info, and adds the blockheight to WIRE_INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Mainly useful for testing. In particular, we don't save it to the db. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Generalize things a bit so OPTIONAL_FEATURE() and COMPULSORY_FEATURE() work with either odd or even features, then explicitly use OPTIONAL_FEATURE in our internal feature array. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/option-extended-gossip-queries
branch
2 times, most recently
from
61a7167
to
adabe9e
Compare
…support. This allows the lightning-rfc protocol tests to automatically query what features we support. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This will never be reliable under high load, without making it unable
to detect real errors. But the test is useful because if we don't
have this test we'll never notice if we break the const-timedness of
our implementation.
So, move the calloc out of the test loop (which seems to make it more
reliable), and then after we've run it, check the 1-minute load
average. Too high, we don't complain about results. It's not
perfect, but it's better.
Running 100 times (-O3) serially gave 100 successes with the following results:
Constant: Within 5% 562-926(832.89+/-73)/1000 times
Non-constant: More than 5% slower 860-990(956.35+/-26)/1000 times
More importantly, if we swap the const and non-const tests, we get
the expected 100 failures:
Non-constant: Within 5% 14-79(41.17+/-14)/1000 times
Constant: More than 5% slower 44-231(111.89+/-33)/1000 times
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/option-extended-gossip-queries
branch
from
adabe9e
to
6911805
Compare
cdecker
reviewed
Aug 29, 2019
lightningd/peer_htlcs.c
Outdated
| @@ -318,6 +318,7 @@ static void handle_localpay(struct htlc_in *hin, | |||
| cltv_expiry, | |||
| get_block_height(ld->topology), | |||
| ld->config.cltv_final); | |||
| /* FIXME! */ | |||
There was a problem hiding this comment.
Fix what? 🙂
NVM, fixed two commits later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.