Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0x00 padding in fromwire_tlv #3301

Closed
darosior opened this issue Nov 28, 2019 · 0 comments · Fixed by #3338
Closed

0x00 padding in fromwire_tlv #3301

darosior opened this issue Nov 28, 2019 · 0 comments · Fixed by #3338

Comments

@darosior
Copy link
Collaborator

darosior commented Nov 28, 2019 •
edited
Loading

Not really an issue -- a reminder of a question I asked @cdecker on IRC.

In https://github.com/ElementsProject/lightning/pull/3300/files#diff-a78f9f800f2058dc93ed8a4d87031956R1038-R1048, I removed test_corruption() as it won't pass because of a 0x00 padding added to init2 in fromwire_tlv. Why do we add this padding ? Is this a mistake on my end ?
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 13, 2019
@rustyrussell
wire: perform corruption test on init_msg.
699e464 
Fixes: ElementsProject#3301
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell added a commit to rustyrussell/lightning that referenced this issue Dec 13, 2019
@rustyrussell
wire: perform corruption test on init_msg.
d15eb8f 
Fixes: ElementsProject#3301
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
@rustyrussell rustyrussell mentioned this issue Dec 13, 2019
Merged
cdecker pushed a commit that referenced this issue Dec 13, 2019
@rustyrussell @cdecker
wire: perform corruption test on init_msg.
b315a29 
Fixes: #3301
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tlv parse fix rustyrussell/lightning
1 participant
@darosior