Commando updating removal version for rpcs #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
changed the title
ShahanaFarooqui
changed the title
ShahanaFarooqui
force-pushed
the
commando-deprecate-rpcs
branch
2 times, most recently
from
6bb5a50
to
7ad45d9
Compare
|
The second commit message does need to explain:
|
We documented them as deprecated in v23.08 but unintentionally didn't deprecate them in the code. Thus we are starting their actual deprecation cycle from v24.08 release. Updating removal version for commands `commando-rune`, `commando-listrunes`, and `commando-blacklist` Changelog-None.
ShahanaFarooqui
force-pushed
the
commando-deprecate-rpcs
branch
from
7ad45d9
to
3709af5
Compare
Thanks, updated the commit and PR message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We documented them as deprecated in v23.08 but unintentionally didn't deprecate them in the code. Thus we are starting their actual deprecation cycle from v24.08 release.
Updated removal version for commands
commando-rune,commando-listrunes, andcommando-blacklist.Changelog-None.