Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configurator image and 2dlayout routes #7

Merged
merged 5 commits into from
Nov 28, 2022

Conversation

jasperoosthoek
Copy link
Contributor

This pull request implements 2 new functions that are missing:

  1. configurator/1/configurator/<ifeatureId>/image: Store the url of an uploaded image in an "image picker" feature
  2. configurator/<configurationId>/2dlayout?stepId=<stepId>: Get the list of images show in the configurator for this particular step.

@johannesheesterman johannesheesterman self-assigned this Nov 28, 2022
Copy link
Contributor

@johannesheesterman johannesheesterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jasperoosthoek
Thank you for your first contribution! The changes look great.

There is just one issue with the type declaration of the OverviewGroups. Could you please accept the suggestion, then we can go ahead and merge these changes.

src/models/Overview.ts Outdated Show resolved Hide resolved
Co-authored-by: johannesheesterman <jheesterman@outlook.com>
@jasperoosthoek
Copy link
Contributor Author

@johannesheesterman It is not possible for me to test the complete module on its own in our development environment. I use copied versions of the files. That's why my changes might contain small errors like this. But I'm very committed to switching over to this module in our custom configurators and I will probably add more changes in the near future.

Thank you for the quick review!

@johannesheesterman
Copy link
Contributor

@jasperoosthoek what you could do for local development is keep a cloned version of the Elfsquad configurator library in a sibling directory to a web testing project.

Then in the testing project you can point to this local version, in your package.json, using:

"dependencies": {
    "@elfsquad/configurator": "file:../configurator"
},

Ensure you build the configurator library before running the testing web project, by running the build commands in the Elfsquad configurator library folder:

npm i
npm run build # OR npm run watch

@johannesheesterman johannesheesterman merged commit ffec0b3 into Elfsquad:main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants