Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time_updated and last_action are wrong on comments after upgrade to 1.9 #6395

Closed
ewinslow opened this issue Feb 3, 2014 · 3 comments
Closed

time_updated and last_action are wrong on comments after upgrade to 1.9 #6395

ewinslow opened this issue Feb 3, 2014 · 3 comments
Assignees
@brettp
Labels
bug critical engine
Milestone
Elgg 1.9.0 Releas...

Comments

@ewinslow
Copy link
Contributor

ewinslow commented Feb 3, 2014

Issue reported by @cash via email a long time ago. Not sure if it ever got reported or whether it's fixed, but figured I'd get it in here so it doesn't get lost.

Another issue with comment upgrade: the update time and last action time is when the new comment objects were created. Recommendations on how to fix this? Only thing I can think of is direct queries rather than using the API.
@mrclay
Copy link
Member

mrclay commented Feb 6, 2014

Bug confirmed, and query would be simplest.

@ewinslow
Copy link
Contributor Author

ewinslow commented Feb 7, 2014

This is the last issue for 1.9-RC1 without a PR! So close!

@ewinslow
Copy link
Contributor Author

ewinslow commented Feb 8, 2014

@Elgg/team-elgg @Elgg/contributors anyone want to own this?

@brettp brettp self-assigned this Feb 9, 2014
brettp added a commit to brettp/Elgg that referenced this issue Feb 9, 2014
@brettp
fix(upgrade): Setting time_updated and last_action for migrated comme…
ed7cf3b 
…nt and discussion entities.

Fixes Elgg#6395.
This was referenced Feb 9, 2014
Merged
Closed
brettp added a commit to brettp/Elgg that referenced this issue Feb 24, 2014
@brettp
fix(upgrade): Correctly settings container guids' last_action times.
acf20d6 
Fixes Elgg#6528
Refs Elgg#6395
brettp added a commit to brettp/Elgg that referenced this issue Feb 24, 2014
@brettp
fix(upgrade): Correctly settings container guids' last_action times d…
9df2367 
…uring comment migration.

Fixes Elgg#6528
Refs Elgg#6395
@brettp brettp mentioned this issue Feb 24, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettp brettp

Labels
bug critical engine
Milestone
Elgg 1.9.0 Release Candidate
Development

No branches or pull requests
3 participants
@brettp @mrclay @ewinslow