fix(upgrade): Correctly settings container guids' last_action times duri... #6572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +56,7 @@ | |||
| // make sure disabled comments stay disabled | |||
| $object->enabled = $annotation->enabled; | |||
| $object->time_created = $annotation->time_created; | |||
| $object->save(); | |||
| $object->save(false); | |||
There was a problem hiding this comment.
What is this argument supposed to do? I don't see it used internally.
There was a problem hiding this comment.
Didn't read far enough :) Ignore.
|
Maybe we should get rid of the separate comment conversion during the upgrade. We know the site if going to migrate comments soon after and having 50 done immediately isn't worth the overhead and the duplicate code. /cc @juho-jaakkola Thoughts? |
|
This LGTM. We can discuss that elsewhere. |
brettp
added a commit
that referenced
this pull request
Mar 1, 2014
…ast_action fix(upgrade): Correctly settings container guids' last_action times duri...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ng comment migration.
Fixes #6528
Refs #6395