Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admins should always get the "gear" icon #9073

Closed
mrclay opened this issue Oct 26, 2015 · 5 comments
Closed

Admins should always get the "gear" icon #9073

mrclay opened this issue Oct 26, 2015 · 5 comments
Labels
ui usability

Comments

@mrclay
Copy link
Member

mrclay commented Oct 26, 2015

i.e. pull it out of the developers plugin. Need to let plugins "unrequire" the module if they want.
@mrclay mrclay mentioned this issue Oct 26, 2015
Closed
@hypeJunction
Copy link
Contributor

Strawman: Move elgg_require_js() call into an extension view, which plugins can overwrite.

@mrclay
Copy link
Member Author

mrclay commented Oct 30, 2015

I have a PR for a simple "unrequire" #9075.

@beck24
Copy link
Member

beck24 commented Oct 30, 2015

elgg_unrequire_js() is more fitting with existing API patterns

@hypeJunction
Copy link
Contributor

Doh, I didn't realize there was a PR for unrequire
On Oct 30, 2015 7:37 PM, "Matt Beckett" notifications@github.com wrote:

elgg_unrequire_js() is more fitting with existing API patterns

—
Reply to this email directly or view it on GitHub
#9073 (comment).

@jdalsem
Copy link
Member

jdalsem commented Aug 4, 2017

Disagree on having the gear always for admins... those tasks are not as daily as you might expect... only causes more js on the page for admins

@jdalsem jdalsem closed this as completed Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui usability
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrclay @beck24 @jdalsem @hypeJunction