feat(views): add attachments and responses to full object listing #10462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdalsem
approved these changes
Oct 17, 2016
mrclay
reviewed
Oct 21, 2016
| echo elgg_view('object/elements/full', array( | ||
| 'entity' => $blog, | ||
| 'summary' => $summary, | ||
| 'icon' => $owner_icon, | ||
| 'body' => $body, | ||
| 'responses' => $responses, |
|
What's the big motivation for this? |
|
More extension points, consistency (plugins can't decide where to render responses - resource view or full view). Plugins can't effectively collaborate on views, it's a constant 'I got here first' battle. As a next step, I want to break out full item views into their own views. |
|
Cool. Is this BC at all for existing plugins? |
|
Should be. It defaults to false so if the replaced resource view renders the comments they won't appear twice. |
hypeJunction
commented
Jan 5, 2017
| ); | ||
| $responses = elgg_view('discussion/replies', $params); | ||
| if ($topic->status == 'closed') { | ||
| $responses = elgg_view('discussion/closed'); |
There was a problem hiding this comment.
Needs to add string not replace
BREAKING CHANGE In core plugins, resource views now longer render comments and replies: instead they pass a show_responses flag to the entity view, which renders the responses and passes them to the listing view. Full discussion view now uses full listing view Full file view now passes file preview as an attachment to the listing view
|
Rebased and addressed the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
In core plugins, resource views now longer render comments and replies:
instead they pass a show_responses flag to the entity view, which
renders the responses and passes them to the listing view.
Full discussion view now uses full listing view
Full file view now passes file preview as an attachment to the listing view