fix(http): Use Symfony to parse PATH_INFO #10618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclay
commented
Nov 22, 2016
engine/classes/Elgg/Application.php
Outdated
| } | ||
| } | ||
| $req = Request::createFromGlobals(); | ||
| $_GET[self::GET_PATH_KEY] = $req->getPathInfo(); |
There was a problem hiding this comment.
I'm assuming here that Request::createFromGlobals handles CLI server, it looks like it should.
mrclay
force-pushed
the
10608_path_info
branch
5 times, most recently
from
6225130
to
3209cf4
Compare
mrclay
changed the title
mrclay
force-pushed
the
10608_path_info
branch
from
3209cf4
to
511adbb
Compare
|
#10609 should go in 2.3, I'll move this to master. |
mrclay
force-pushed
the
10608_path_info
branch
from
511adbb
to
3bf034d
Compare
mrclay
changed the title
mrclay
force-pushed
the
10608_path_info
branch
2 times, most recently
from
f2ed222
to
ccb5101
Compare
|
Anything holding this back? |
mrclay
force-pushed
the
10608_path_info
branch
from
ccb5101
to
cbb60ce
Compare
mrclay
changed the title
mrclay
force-pushed
the
10608_path_info
branch
from
cbb60ce
to
43dbe96
Compare
mrclay
commented
Jan 13, 2017
| @@ -76,6 +76,5 @@ server { | |||
| include /etc/nginx/fastcgi_params; | |||
| fastcgi_param SCRIPT_FILENAME $document_root/index.php; | |||
| fastcgi_param SCRIPT_NAME /index.php; | |||
| fastcgi_param QUERY_STRING __elgg_uri=$uri&$args; | |||
There was a problem hiding this comment.
I've not tested this removal
|
Anyone else wanna test it? |
|
We should add Travis jobs for both apache and ngnix perhaps |
|
@Elgg/core I'm merging this Apr 10 if no objections. |
jeabakker
approved these changes
Apr 5, 2017
Instead of having Apache rewrite the path into a query string argument, we use Symfony's battle-tested `Request::getPathInfo`. Fixes Elgg#10608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having Apache rewrite the path into a query string argument, we use Symfony's battle-tested
Request::getPathInfo.Fixes #10608