Some changes to group saving logic #10664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypeJunction
commented
Dec 16, 2016
|
|
||
| // Update owned metadata | ||
| $metadata = elgg_get_metadata([ | ||
| 'guid' => $group->guid, |
There was a problem hiding this comment.
We could use metadata_owner_guids here, I suppose
hypeJunction
commented
Dec 17, 2016
| $previous_owner_guid = $original_attributes['owner_guid']; | ||
|
|
||
| // In addition to standard icons, groups plugin stores a copy of the original upload | ||
| $filehandler = new ElggFile(); |
There was a problem hiding this comment.
We don't need this anymore. Group icons are already owned by the group.
|
So far so good |
Group name changes that take place outside of the groups/edit action are now correctly reflected in access collections table
…rship Group metadata ownerships is now correctly updated if group owner changes outside of the groups/edit action
Makes it easier to supply a container_guid for a new group without having to replace an entire action. Makes sure the user can write a new group to container, thus making it easier to implement more granular controls over who can create new groups
hypeJunction
changed the title
|
I am done with this one. |
The upgrade script overlooked the fact that groups plugin kept a copy of the originally uploaded image. This corrects the issue
|
There was also an issue with group icon upgrade. Adding it to this PR, so we don't have to deal with conflicts later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(groups): group ACL name is now always in sync with the group name
Group name changes that take place outside of the groups/edit
action are now correctly reflected in access collections table
feat(groups): group metadata ownership in now in sync with group ownership
Group metadata ownerships is now correctly updated if group
owner changes outside of the groups/edit action
feat(groups): validate container permissions when creating a new group
Makes it easier to supply a container_guid for a new group without having to
replace an entire action.
Makes sure the user can write a new group to container, thus making it
easier to implement more granular controls over who can create new groups