feature(comments): Added separate edit page for generic comments.php

[Srokap]

That handles case when user opens edit link in new tab.

Fixes #6666

• Cancel button doesn't work
• Maybe forward to container on save?

[ewinslow]

We should be careful with this word "subject". I initially thought you meant the grammatical subject as in the author or the person who wrote the comment, as opposed to the topic that was being commented on (i.e. blog, etc.).

I'd prefer "target" as that's what it is in the river now.

[Srokap]

Ok, good that you mention it.

[ewinslow]

LGTM, aside from the one minor variable-naming nit.

[Srokap]

Corrected and amended commit..

[mrclay]

Two issues:

1. After saving it leaves you back on the edit page; wouldn't it be more helpful to forward to the container?
2. Do we really need to handle this (users middle-clicking on arbitrary UI elements)? This only opens a new window because we used a link, when really this should semantically be a button.

[ewinslow]

If we only want this functionality available via JS, we need to actually make it a <button>. But that seems like its more hassle than its worth right now, no?

[Srokap]

Ad. 1. Yes I don't like it either, but wanted to avoid messing with action as I will have to add some weird condition in action or add some additional parameter in the form. Also "cancel" link don't work

Ad. 2. I think it's nice practice that makes at least dev life easier in case of javascript crash. I wouldn't be surprised if it was a good accessibility practice. I'm trying to make it reuse as much as possible and keep it simple.

I'll see what can be done with minimal changes.

[ewinslow]

@Srokap any updates on this?

[mrclay]

See #6753.