perf(upgrade): ajaxifies data directory migration #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll test all three XHR upgrades tomorrow with a clone of the community site. |
|
LGTM |
|
Testing the upgrades on community would be awesome! Thanks! |
| } | ||
| $upgrade = new ElggUpgrade(); | ||
| $upgrade->setURL("admin/upgrades/datadirs"); | ||
| $upgrade->title = 'Data directory upgrade'; |
There was a problem hiding this comment.
Should these be translatable?
There was a problem hiding this comment.
I'm not 100% sure, but apparently new translation strings aren't available at this point of the upgrade.
|
Ship it! |
This allows upgrade.php to complete more quickly by moving the user data directory migrations to a separate page with an ajax process. Fixes Elgg#6202
juho-jaakkola
pushed a commit
that referenced
this pull request
Apr 17, 2014
perf(upgrade): ajaxifies data directory migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows upgrade.php to complete more quickly by moving the user data directory migrations to a separate page with an ajax process.
Fixes #6202
Replaces #6336
Changes to Steve's original PR: