feature(composer): Fully support installing Elgg as a composer dependency #8481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ency This change makes it *necessary* to install Elgg as a composer dependency. It is not possible to run it any other way at this point because so many relative paths assume that Elgg is installed at /vendor/elgg/elgg/. Fixes Elgg#8431
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it necessary to install Elgg as a composer dependency.
It is not possible to run it any other way at this point because so many
relative paths assume that Elgg is installed at /vendor/elgg/elgg/.
Fixes #8431
For this to be useful enough to pull in I think we really need to: