chore(aalborg_theme): Returns caret to avatars on hover #8650
Conversation
|
this change in Aalborg was intentionally done for touch i believe... this now introduces the "default" elgg problem that you have problems reaching the dropdown menu with touch devices... |
|
otherwise LGTM |
|
I certainly don't want to interfere with touch. @PerJensen got a recommendation here? |
|
The graphics were added to make it easier to hit on touch screens. It is just as large as the icon profile, 40 x 40, as opposed to the default which is 16 x 16. |
|
@jdalsem Have you tested this? What particularly in my changes would break the existing touch-to-open behavior? |
| position: absolute; | ||
| bottom: 0; | ||
| right: 0; | ||
| color: #fff; |
There was a problem hiding this comment.
do not change to white as that cause visual issues... just leave as default (or switch to aalborgs BLACK color, as used in the image)
|
@mrclay tested it, and this approach has no touch issues. If you could respond to the color comment and also remove the image from the aalborgtheme this is good to merge |
BREAKING CHANGE: The file mod/aalborg_theme/graphics/avatar_menu_arrows.png has been removed. Fixes Elgg#8629
chore(aalborg_theme): Returns caret to avatars on hover
BREAKING CHANGE:
The file mod/aalborg_theme/graphics/avatar_menu_arrows.png has been removed.
Fixes #8629