Just always have the parenthesized note on the step name #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would also have the benefit of stopping using the "a && b || c" fake ternary conditional, which is brittle. The issue here is that I don't know what variables I can define that I can interpolate into a *step name*. But using a CI matrix variable, as here, does not seem to be workable.
The complex logic in the interpolated name was very bad, both in terms of the workflow's clarity and maintainability, and in that it used the brittle fake ternary conditional a && b || c. I had only introduced that a stopgap while trying to figure out a better way to express it. I didn't, and it's better not to have the feature that only provides the parenthesized note when needed, than to have it but write it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complex logic in the interpolated name was very bad, both in terms of the workflow's clarity and maintainability, and in that it used the brittle fake ternary conditional a && b || c. I had only introduced that a stopgap while trying to figure out a better way to express it. I didn't, and it's better not to have the feature that only provides the parenthesized note when needed, than to have it but write it this way.