Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][10.0-Issue175-T23298] ldap_password #177

Conversation

sudhir-serpentcs
Copy link

@sudhir-serpentcs sudhir-serpentcs commented Aug 25, 2017

Migrated ldap_password in v10.
@elicoidal @seb-elico @victormartinelicocorp Please review.
This PR refers to issue #175

@sudhir-serpentcs sudhir-serpentcs mentioned this pull request Aug 25, 2017
11 tasks
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some details on my side.
Not sure about the demo data and the tests here

@@ -1,5 +1,5 @@
# -*- coding: utf-8 -*-
# © <2010-2015> <Augustin Cisterne-Kaas>
# © 2017 Elico corp (www.elico-corp.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2015-2017 (you need to keep the original date always)

@@ -1,19 +1,19 @@
# -*- coding: utf-8 -*-
# © 2015 Elico Corp (www.elico-corp.com)
# © 2017 Elico corp (www.elico-corp.com)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2015-2017 Elico Corp (https://www.elico-corp.com)

(same everywhere)

@elicoidal elicoidal added this to the 10.0 milestone Sep 5, 2017
Copy link
Contributor

@victormmtorres victormmtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be tested

@elicoidal elicoidal merged commit d6b6910 into Elico-Corp:10.0 Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants