Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mostly more type safety! (for anify db functions) #7

Merged
merged 1 commit into from
Sep 26, 2023
Merged

mostly more type safety! (for anify db functions) #7

merged 1 commit into from
Sep 26, 2023

Conversation

skearya
Copy link
Contributor

@skearya skearya commented Sep 26, 2023

improvements:

  • remove a LOT of (x as any)
  • typed db queries
  • removal of some unnecessary awaits (bun's sqlite is not async)
  • other small type stuff

as always please make sure everything still runs fine

@skearya skearya changed the title mostly more type safety! mostly more type safety! (for anify db functions) Sep 26, 2023
@skearya
Copy link
Contributor Author

skearya commented Sep 26, 2023

i did set the type of anime's "type" to Type.Anime and did the same thing for manga
image
was there a reason for the type not being this way?

@Eltik
Copy link
Owner

Eltik commented Sep 26, 2023

No there wasn't LOL
Tysm for the PR :) Really appreciate it!!

@Eltik Eltik marked this pull request as ready for review September 26, 2023 12:41
@Eltik Eltik merged commit 8e67aba into Eltik:main Sep 26, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skearya @Eltik