Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom separator to filenamePattern #174

Closed
wants to merge 1 commit into from
Closed

feat: add custom separator to filenamePattern #174

wants to merge 1 commit into from

Conversation

mengshouer
Copy link

I don't know Japanese, so I use translation software for Japanese i18n.

@EltonChou
Copy link
Owner

EltonChou commented Jun 20, 2024

Thanks for your PR.

Several problems need to be solved,

  1. Can all characters be in a valid filename or path in most OS ?
  2. Can this feature be easily adopted by most of the users without any unexpected error ?
  3. If error happens, how do they get the feedback ?
  4. Providing a well-tested seperator list rather than an input ?
  5. Is the generated filename easily parsed ?

@mengshouer
Copy link
Author

I hadn't thought about it much, and there are some special characters that different operating systems don't allow. You can set the option to turn it off by default and consider adding a warning flag if you want to use it or turn off the PR.

Since I'm changing it for my own use, I can just use the locally built version.

@mengshouer mengshouer closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants