-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend multiselection prompt with pagesize option (#65) #66
feat: extend multiselection prompt with pagesize option (#65) #66
Conversation
Hi @groma84, thanks for the contribution! We just pushed/merged a PR fixing the build. If you rebase now you can test your changes. It happened due to some simultaneous changes from both of us. We'll ad a CI build action soon to prevent this in the future! |
Thanks for all the feedback - I'll work on the PR again on Thursday and will include all your suggested improvements! |
34cb171
to
af11adb
Compare
I implemented the suggestions but I still can't build the -cli project locally, even after rebasing: (sorry for the German messages, basically it says Count and ToArray aren't defined) ...\SpectreCoff\src\spectrecoff-cli\commands\Prompt.fs(19,28): error FS0039: Das Feld, der
Konstruktor oder der Member "Count" ist nicht definiert. [C:\workspace\groma84@github.com\SpectreCoff\src\spectrecoff-c
li\SpectreCoff.Cli.fsproj]
...\SpectreCoff\src\spectrecoff-cli\commands\Prompt.fs(22,44): error FS0039: Das Feld, der
Konstruktor oder der Member "ToArray" ist nicht definiert. [C:\workspace\groma84@github.com\SpectreCoff\src\spectrecoff
-cli\SpectreCoff.Cli.fsproj]
...\SpectreCoff\src\spectrecoff-cli\commands\Prompt.fs(25,53): error FS0039: Das Feld, der
Konstruktor oder der Member "Count" ist nicht definiert. [C:\workspace\groma84@github.com\SpectreCoff\src\spectrecoff-c
li\SpectreCoff.Cli.fsproj] |
Hi Martin, I checke out your branch to investigate, and this time, unfortunately (or is it, hehe) the build error is due to your changes. As you can see in this screenshot I checked out two commits backwardds on your branch to the main state, and the build succeeds: I guess the type inference is now defaulting to Seq instead of List on one of the underlying methods. Maybe you need to add some types nonetheless. I did a quick fix and pushed it to the branch. Feel free to rework the commit, if you think I overstepped! |
Thanks for the fix! |
I extended MultiSelectionPrompt with MultiSelectionPromptOptions to allow setting the PageSize
I could not actively test it because the freshly cloned main branch does not build sadly.