Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.icons #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

README.icons #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/icons/README.icons
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
please explain why there are so many different sized icons

* for example, what purpose does each one serve?

* and how and where should each be used?

* for example, which is appropriate for `Ext.browserAction.setIcon()`?

* is there a particular reason why there are exactly 5 icons?

* why these specific sizes? are they pixel-perfect for some browsers?
- if not, then why the odd sizes like 19 instead of all powers of 2?

only 2 of them are referenced - both in the manifest.json:

"default_icon": {
"19": "icons/icon-19.png",
"38": "icons/icon-38.png"
},

* why are there multiple "default" icons? (the word "default" implies only "one")

* the mozilla docs vaguely indicate that the browser may select icons from the set depending on screen size
- but is there a particular reason why there are exactly 2 "default" icons - why not 1, 3, or 4?