Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecation message. #16

Merged
merged 1 commit into from
Aug 3, 2017

Conversation

DenysMedvid
Copy link
Contributor

Referencing the ... extension by its name (defined by getName()) is deprecated since 1.26 and will be removed in Twig 2.0. Use the Fully Qualified Extension Class Name instead

We can not use getName method.
Also, added registration of parent Extension.

This PR linked to asm89/twig-cache-extension#37

@coveralls
Copy link

coveralls commented Oct 4, 2016

Coverage Status

Coverage increased (+0.5%) to 67.123% when pulling cdc5400 on DenisMedved:master into fc30247 on EmanueleMinotto:master.

@sc0rp10
Copy link

sc0rp10 commented Oct 4, 2016

+1

1 similar comment
@tjveldhuizen
Copy link

+1

@DenysMedvid
Copy link
Contributor Author

PR asm89/twig-cache-extension#37 has merged.

@EmanueleMinotto
Copy link
Owner

Sorry @DenisMedved but I don't get wat's changed here, could you add at least a test, please?

@DenysMedvid
Copy link
Contributor Author

After all updates i cannot reproduce message again.
So, i think this PR should be closed .

@DenysMedvid
Copy link
Contributor Author

Looks like this PR can fix #17

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 67.123% when pulling cdc5400 on DenisMedved:master into fc30247 on EmanueleMinotto:master.

@keesschepers
Copy link

For us it also fixed #17 so I would opt to merge it if possible.

@nuffer
Copy link

nuffer commented Jan 9, 2017

+1

2 similar comments
@mullerch
Copy link

mullerch commented Jan 9, 2017

+1

@ahilles107
Copy link
Contributor

👍

@multifinger
Copy link

Why so long (((

@multifinger
Copy link

To use provided FIX in composer I've forked DenisMedved repo and tagged it with bugfix branch
So you can use it like this in composer.json:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/multifinger/TwigCacheBundle"
        }
]

and

"require": {
    "emanueleminotto/twig-cache-bundle": "dev-bugfix"
}

Additionaly you may need to generate git OAuth token to prevent API rate limit

@DenysMedvid
Copy link
Contributor Author

As temporary solution, you can attach fork repository

repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:DenisMedved/twig-cache-extension.git"
        },
        {
            "type": "vcs",
            "url": "git@github.com:DenisMedved/TwigCacheBundle.git"
        }
    ],
    "require": {
          ...
        "exercise/htmlpurifier-bundle": "dev-master",
        "emanueleminotto/twig-cache-bundle": "dev-custom",
       ...
    },

@EmanueleMinotto
Copy link
Owner

Sorry guys, tbh I don't have time to maintain this bundle, I'll try to take a look this evening but I'm not sure if I'll have time.
Anyway if someone is interested in maintaining it, just write me and I'll add you. :)

@EmanueleMinotto EmanueleMinotto merged commit 4861c3f into EmanueleMinotto:master Aug 3, 2017
@EmanueleMinotto
Copy link
Owner

Time to merge 👍
I'm really sorry for the delay and thank you for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants