-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix deprecation message. #16
Conversation
+1 |
1 similar comment
+1 |
PR asm89/twig-cache-extension#37 has merged. |
Sorry @DenisMedved but I don't get wat's changed here, could you add at least a test, please? |
After all updates i cannot reproduce message again. |
Looks like this PR can fix #17 |
For us it also fixed #17 so I would opt to merge it if possible. |
+1 |
2 similar comments
+1 |
👍 |
Why so long ((( |
To use provided FIX in composer I've forked DenisMedved repo and tagged it with bugfix branch "repositories": [
{
"type": "vcs",
"url": "https://github.com/multifinger/TwigCacheBundle"
}
] and "require": {
"emanueleminotto/twig-cache-bundle": "dev-bugfix"
} Additionaly you may need to generate git OAuth token to prevent API rate limit |
As temporary solution, you can attach fork repository
|
Sorry guys, tbh I don't have time to maintain this bundle, I'll try to take a look this evening but I'm not sure if I'll have time. |
Time to merge 👍 |
We can not use getName method.
Also, added registration of parent Extension.
This PR linked to asm89/twig-cache-extension#37