Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for running without cargo.exe installed #54

Closed
repi opened this issue Dec 11, 2019 · 2 comments · Fixed by #243
Closed

Support for running without cargo.exe installed #54

repi opened this issue Dec 11, 2019 · 2 comments · Fixed by #243
Labels
enhancement New feature or request

Comments

@repi
Copy link
Contributor

repi commented Dec 11, 2019

Currently as we use cargo_metadata crate the user running cargo-deny also have to have the full Cargo toolchain installed, in other words: cargo-deny is not a fully standalone executable.

This is ok and good for the default use case as it is very likely a user that is interested in using cargo-deny also have Cargo and Rust installed :)

But for CI and/or minimal docker images it would be nice if we had an optional feature flag for using the cargo crate and output_metadata directly on it instead of invoking cargo.exe. Can still take the .json output and feed it into cargo_metadata to leave the rest of the code and parsing unchanged.

@repi repi added the enhancement New feature or request label Dec 11, 2019
@Jake-Shadle
Copy link
Member

I now know what problems you ran into in test action. 😉

@repi
Copy link
Contributor Author

repi commented Dec 11, 2019

Spy! :)

Installing Cargo and getting it in the environment properly turned out to be harder than expected, and way fatter image, and ideally unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants