-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement standalone feature #243
Conversation
Since this is the first feature for cargo-deny, you should probably modify https://github.com/EmbarkStudios/cargo-deny/blob/main/.github/workflows/ci.yaml#L103 to use the feature so that it gets coverage. |
nice! For the published binaries of cargo-deny, should we also switch them to use this instead so they don't require Rust & Cargo to be installed? The extra build time for that CI publish step shouldn't be too bad. And then we can simplify the cargo-deny-action to reduce its size as it doesn't need the full Rust environment (tracked in EmbarkStudios/cargo-deny-action#3). The nice thing about that approach is that users building cargo-deny locally (which obviously have Rust installed) will build and use with that, without having to build the Cargo crate, and same if one does |
Yah, that's probably a good idea, though I would need to add a new test to actually run it in an isolated environment, as there might be some dependencies with regards to environment variables being available that won't be set etc. |
I think it's better if you add the changes to the release process, because I have no idea about the CI part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not merging this sooner, thanks a lot for this change!
This PR introduces the new build feature
standalone
.If this feature is enabled,
cargo-deny
doesn't use thecargo
binary on the system, but thecargo
crate.Resolves #54