Make version requirements truly optional #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the various config options in the
bansandlicensesthat allow specifying a crate had an optionalversioncomponent that could be used to restrict the match to a specific semver range. If none was specified, this would default to the*wildcard match to match any version of the crate. However,*has a non-intuitive interaction with pre-releases...they actually won't match. This causes user confusion since pre-releases are relatively rare in the rust ecosystem, and most people (myself included) think that*means everything, not everything, except for this niche case. So now, all configVersionReqs are actually optional, and if not specified will match any version.Even though this is technically a breaking change, I actually consider this a bug fix and will release it as such.
Resolves: #371