Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version requirements truly optional #393

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

Jake-Shadle
Copy link
Member

Previously, the various config options in the bans and licenses that allow specifying a crate had an optional version component that could be used to restrict the match to a specific semver range. If none was specified, this would default to the * wildcard match to match any version of the crate. However, * has a non-intuitive interaction with pre-releases...they actually won't match. This causes user confusion since pre-releases are relatively rare in the rust ecosystem, and most people (myself included) think that * means everything, not everything, except for this niche case. So now, all config VersionReqs are actually optional, and if not specified will match any version.

Even though this is technically a breaking change, I actually consider this a bug fix and will release it as such.

Resolves: #371

@Jake-Shadle Jake-Shadle merged commit 927c9d1 into main Jan 27, 2022
@Jake-Shadle Jake-Shadle deleted the semver-wildcard branch January 27, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Fix" wildcard version matching
1 participant