Add osi and fsf values for allow-osi-fsf-free config
#531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR resolves EmbarkStudios#210 by adding `osi` and `fsf` as new values for `allow-osi-fsf-free. This allows for the use case where a cargo-deny user wants to blanket allow all FSF licenses while not caring about OSI (or vice versa).
zkxs
added a commit
to zkxs/cargo-deny
that referenced
this pull request
Jul 25, 2023
I had initially patterned the check on `OsiOnly` and `FsfOnly` before realizing that perhaps deny!() didn't make sense here, and I removed it (or so I thought). It seems I blundered and left one in--sorry. I believe this deny!() shouldn't be here. Apologies for the mistake... (Also, thanks for catching that other mistake I made in EmbarkStudios#531 Jake)
zkxs
added a commit
to zkxs/cargo-deny
that referenced
this pull request
Jul 25, 2023
I had initially patterned the new license checks on `OsiOnly` and `FsfOnly` before realizing that perhaps deny!() didn't make sense here, and I removed it (or so I thought). It seems I blundered and left one in--sorry. I believe this deny!() shouldn't be here. Apologies for the mistake... (Also, thanks for catching that other mistake I made in EmbarkStudios#531 Jake)
Jake-Shadle
pushed a commit
that referenced
this pull request
Jul 25, 2023
I had initially patterned the new license checks on `OsiOnly` and `FsfOnly` before realizing that perhaps deny!() didn't make sense here, and I removed it (or so I thought). It seems I blundered and left one in--sorry. I believe this deny!() shouldn't be here. Apologies for the mistake... I thought I'd double-checked my diff but it seems I did a poor job of it. (Also, thanks for catching that other mistake I made in #531 Jake)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #210 by adding
osiandfsfas new values forallow-osi-fsf-free. This allows for the use case where a cargo-deny user wants to blanket allow all FSF licenses while not caring about OSI (or vice versa).