Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update builtin targets to Rust 1.54.0 #38

Merged
merged 5 commits into from
Aug 31, 2021

Conversation

sunshowers
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

This includes several changes:

  1. Rust 1.54 introduces the new WASM target family. More target families
    might be added in the future, so make this enum open-ended like Arch, Os
    and others.
  2. Use builtin constants for target-lexicon matching.
  3. Update the builtin targets and target-lexicon, and handle the new bpf
    architectures and wasm family.

Rust 1.54 introduces the new WASM target family. More target families
might be added in the future, so make this enum open-ended like Arch, Os
and others.
The builtin constants avoid stringly-typed bugs.
Requires an update to target-lexicon, and handling for the new bpf
architectures and wasm family.
@sunshowers
Copy link
Contributor Author

I believe that with this change a new version of cfg-expr can be released.

Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the PR! I'll do a release with this later today.

src/targets.rs Outdated Show resolved Hide resolved
src/targets.rs Outdated Show resolved Hide resolved
@Jake-Shadle Jake-Shadle self-requested a review August 31, 2021 06:27
@Jake-Shadle Jake-Shadle merged commit 64b4608 into EmbarkStudios:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants