Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support win32 thread #108

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

wesley-wu
Copy link
Contributor

support multithread on the windows.

@MichalPrincNXP
Copy link
Member

Hello @wesley-wu , thank you for this PR, please give me some time to review and evaluate. Thank you.

@MichalPrincNXP MichalPrincNXP self-requested a review August 3, 2020 21:33
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wesley-wu , your pull request looks good and ready to be accepted.
Similar to #81, win32 app. build testing would require certain effort (to setup the build environment on our side). Because it is out of our focus now we can accept your PR, supposing you have tested the win32 port in your project. Once there are any issues reported to the win32 port we will route them to you. Are you OK?
Another way how to ensure win32 build testing is the Travis. Would you be able to prepare erpc project .travis.yml update to add an win32 erpc app build? This could be done as a separate PR. Thanks.

@wesley-wu
Copy link
Contributor Author

hello @MichalPrincNXP , It's OK, you can route the win32 port issues to me.
I will try to setup win32 build testing on another PR.

@MichalPrincNXP
Copy link
Member

OK, great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants