Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inout cases. #237

Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Feb 2, 2022

This is solving all inout issue which are not covered by #46.
Also merge is set into correct repository.

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko self-assigned this Feb 2, 2022
@Hadatko
Copy link
Member Author

Hadatko commented Feb 2, 2022

This took me much more time than i expected. We still need add tests for these changes. All current tests are passing.

@Hadatko Hadatko added the bug label Feb 2, 2022
@Hadatko Hadatko added this to the 1.9.1 milestone Feb 2, 2022
@Hadatko Hadatko linked an issue Feb 2, 2022 that may be closed by this pull request
@Hadatko Hadatko linked an issue Feb 2, 2022 that may be closed by this pull request
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need add tests for these changes.
yes, agree, python implementation tests are on TODO list

@MichalPrincNXP MichalPrincNXP merged commit ce76b86 into EmbeddedRPC:develop Feb 3, 2022
@Hadatko Hadatko deleted the bugfix/fix_inout branch February 4, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Python inout fn parameters
2 participants