Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better distuingish which file can and cannot by compiled with C compiler. #266

Merged
merged 3 commits into from
Jun 10, 2022
Merged

Better distuingish which file can and cannot by compiled with C compiler. #266

merged 3 commits into from
Jun 10, 2022

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented May 3, 2022

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

Renaming C++ header files extensions from .h to .hpp. This can inform programers which header files shouldn't be compiled with C compiler (do not include in .c files).

To Reproduce

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested. -> The part which i can test.
  • PR code is formatted.

Additional context

@Hadatko Hadatko self-assigned this May 3, 2022
@Hadatko Hadatko force-pushed the feature/rename_erpcgen_headerfiles branch from ca42702 to f3798a6 Compare May 3, 2022 14:41
@Hadatko Hadatko added this to the 1.10.0 milestone May 3, 2022
@Hadatko Hadatko force-pushed the feature/rename_erpcgen_headerfiles branch from f3798a6 to 2a3042d Compare June 8, 2022 11:38
@Hadatko
Copy link
Member Author

Hadatko commented Jun 8, 2022

@MichalPrincNXP I believe this is ready for merge

@MichalPrincNXP
Copy link
Member

MichalPrincNXP commented Jun 9, 2022 •
edited
Loading

There are several unit test sources where the workaround for Compiler redefinition errors in arm_compat.h have been applied recently. This is related to the update to CMSIS 5.8.0 in the MCUXpressoSDK.

  • ensure the arm_compat.h is included before the CMSIS compliant device-specific header file, in our case the rpmsg_compiler.h needs to be included as first where needed
  • Article ID: KA004795 on developer.arm.com

Could you please keep the include order in following files?
unit_test_server.cpp

@Hadatko
Revert unit_test_server.cpp include order.
36c9c9b 
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko
Copy link
Member Author

Hadatko commented Jun 9, 2022

Is it ok now?

@MichalPrincNXP
Copy link
Member

Is it ok now?

Yes, thanks, I am still testing on boards ...

MichalPrincNXP
MichalPrincNXP approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@MichalPrincNXP MichalPrincNXP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Onboard testing finished, just a minor update in unit_test_client.cpp needed:
gtestListener.h -> gtestListener.hpp
myAlloc.h -> myAlloc.hpp

@MichalPrincNXP MichalPrincNXP merged commit 60a3cc1 into EmbeddedRPC:develop Jun 10, 2022
@MichalPrincNXP
Copy link
Member

Thank you, Dusan

MichalPrincNXP added a commit that referenced this pull request Jun 10, 2022
@MichalPrincNXP
Update of PR #266 - Disable copy ctor and &operator in erpc_transport…
cd8ffc8 
…_arbitrator.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalPrincNXP MichalPrincNXP MichalPrincNXP approved these changes

Assignees

@Hadatko Hadatko

Labels
enhancement
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Hadatko @MichalPrincNXP