Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CI tests. #289

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Conversation

Hadatko
Copy link
Member

@Hadatko Hadatko commented Jun 20, 2022

Signed-off-by: Cervenka Dusan cervenka@acrios.com

Pull request

Choose Correct

  • bug
  • feature

Describe the pull request

Currently the shell scripts may failed but CI will not show errors.

To Reproduce

Add error to any shell step and run CI.

Expected behavior

CI will show failures

Screenshots

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if other PR isn't solving this issue.
  • I read Contribution details and did appropriate actions.
  • PR code is tested.
  • PR code is formatted.

Additional context

@Hadatko Hadatko force-pushed the bugfix/fixCI branch 6 times, most recently from 4811c63 to 1d798d2 Compare June 20, 2022 17:41
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
@Hadatko Hadatko changed the title Dummy Fixing CI tests. Jun 20, 2022
@Hadatko
Copy link
Member Author

Hadatko commented Jun 20, 2022

Hi @MichalPrincNXP,
we had serious issues with testing erpc using CI. Some of them appeared with using scripts. Now it should work as intended but i don't like much solution in conftest.py file. I will try to update it asap.
But until then i would merge this PR if you agree and provide other solution if i will find. What do you think?

@Hadatko Hadatko self-assigned this Jun 20, 2022
@Hadatko Hadatko added the bug label Jun 20, 2022
@Hadatko Hadatko added this to the 1.10.0 milestone Jun 20, 2022
@MichalPrincNXP MichalPrincNXP merged commit 92203a3 into EmbeddedRPC:develop Jul 1, 2022
@Hadatko Hadatko deleted the bugfix/fixCI branch July 1, 2022 08:19
@MichalPrincNXP
Copy link
Member

Hi @MichalPrincNXP, we had serious issues with testing erpc using CI. Some of them appeared with using scripts. Now it should work as intended but i don't like much solution in conftest.py file. I will try to update it asap. But until then i would merge this PR if you agree and provide other solution if i will find. What do you think?

I agree, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants