Change default build target to release + adding artefacts #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hadatko
force-pushed
the
bugfix/byDefaultRelease
branch
from
2195c24
to
ad52616
Compare
|
Now binary files are available for all users: |
|
@MichalPrincNXP Ready for merge |
Can you add also windows erpcgen to artifacts (if it not exist already)? |
|
Hi @amgross , i would like to add windows and mac in near future. But both have complication. I don't know why i cannnost enable mac target as it should be allowed. Communicating with circleci. I want recreate mingw support and provide windows application build this way. |
|
Happy to hear, |
|
@amgross No problem ;) We are happy that you are helping us a lot on other fronts. |
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
MichalPrincNXP
force-pushed
the
bugfix/byDefaultRelease
branch
from
8c42a08
to
c693edb
Compare
MichalPrincNXP
approved these changes
Jan 25, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cervenka Dusan cervenka@acrios.com
Pull request
Choose Correct
Describe the pull request
It doesn't make sense to have default target debug as it is for debugging builds, but as default we wan't debug them but only build and use. If they are failing then we wan't build debug target and debug issue.
Our comments is saying same:
+++ Ading artefacts so we will have available binaries for every build. Users may benefit to get nightly-version of eRPC app.
To Reproduce
previously we need modify build var for getting release target. Now we need to modify it for debug.
Expected behavior
Build release target by default
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context