-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed clang configuration file #360
Fixed clang configuration file #360
Conversation
+ reformatted code. Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Hi Dusan, thank you. Would it be possible to move to LLVM16 to be aligned with MCUXpressoSDK formatting? |
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Hi @MichalPrincNXP, does last commit matched your preference? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strings should not have wrapping with quotes.
The following one is questionable:
BreakInheritanceList: "BeforeComma"
I propose to use any from rest of two values
Hi @isolansky , i don't understand your first line. If we want to be consistent we can take a look how it looks like in initializing contructor. Newline is before comma. Then we need change both. But personally this is cleaner as comma is aligned with ":" |
From my understanding, goal is to have code, easily mergable with other projects (under MCUX) or using MSDK in other way. |
I think you are mixing apples and pears ;) We are trying to align C++ code style with NXP code style. But NXP doesn't have C++ code style (afaik) so we should discuss what is best for C++ specific cases. My suggestion looks like block so easier to read. Anyway as mentioned before. If we do your requested change it would lead to inconsistency with constructor declaration. So we need keep current settings or change both. (it looks this type of inconsistency is present in webkit. Do you still like Mozilla? They are using my proposed change :D) |
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
-- includes will not be sorted at all (not even in groups) -- Constructutor and inheritance will use AfterColon format style Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
54fc38d
to
4038a86
Compare
1fe593f
to
b43796f
Compare
Update clang-format version Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
b43796f
to
326a65d
Compare
@MichalPrincNXP @isolansky Your requests are placed. I noticed that clang check was not call on PR change so i added this option and moved excluded files list to its own file so we can have one source of excluded files for two different usage of clang format. |
Thank you, also for pointed out that include sorting based on grouping. This will be subject of future consideration. |
@isolansky That sounds great. Also in that case you would have to use: |
…updateClangConfig Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
FYI: @MichalPrincNXP this should be ready too. |
thank you, Dusan |
Pull request
Choose Correct
Describe the pull request
I noticed that some clang-format config values were changed for version we have. So i adapt them and added one more which was not available.
To Reproduce
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context